Add support for NXP S32K148 evaluation board #85555

marcin-wierzbicki · 2025-02-11T08:39:04Z

Add support for NXP S32K148 evaluation board.

The board can be debugged using gdb (see boards/nxp/s32k148_evb/doc/index.rst).
The board cannot be debugged using the west debug command, since pyOCD does not support the target. I would be grateful for any guidance on this.

Adapt samples: adc_dt, adc_sequence.
Adapt tests: adc_api, gpio_basic_api, gpio_hogs.

See Add support for S32K148 SoC

drivers/ethernet/nxp_enet/Kconfig

manuargue · 2025-02-11T10:19:24Z

See zephyrproject-rtos/hal_nxp#509

@marcin-wierzbicki please update the hal_nxp entry in the west manifest to point to that pr

manuargue · 2025-02-11T10:26:52Z

Add driver for TJA1101 PHY device.

I'd recommend to keep this first PR smaller including basic enablement of the SoC and board, and split the PHY driver into another PR for easier review. This will likely also help you to move the prs faster. This is not mandatory, but in general a good practice.

boards/nxp/s32k148_evb/doc/img/s32k148_evb.webp

nordicjm · 2025-02-12T10:24:27Z

boards/nxp/s32k148_evb/doc/index.rst

+Supported Features
+==================
+
+The ``s32k148_evb`` board configuration supports the following hardware features:


Suggested change

The ``s32k148_evb`` board configuration supports the following hardware features:

The ``s32k148_evb`` board supports the following hardware features:

stop marking things as resolved if they are not resolved and fix the highlighted issue

boards/nxp/s32k148_evb/doc/index.rst

boards/nxp/s32k148_evb/s32k148_evb.dts

boards/nxp/s32k148_evb/s32k148_evb_defconfig

drivers/ethernet/phy/CMakeLists.txt

drivers/ethernet/nxp_enet/Kconfig

dts/arm/nxp/nxp_s32k148.dtsi

boards/nxp/s32k148_evb/s32k148_evb.dts

drivers/ethernet/phy/phy_tja1101.c

boards/nxp/s32k148_evb/s32k148_evb.yaml

marcin-wierzbicki · 2025-02-14T09:18:58Z

Add driver for TJA1101 PHY device.

I'd recommend to keep this first PR smaller including basic enablement of the SoC and board, and split the PHY driver into another PR for easier review. This will likely also help you to move the prs faster. This is not mandatory, but in general a good practice.

Sure. Thank you.

zephyrbot · 2025-02-17T09:56:40Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`2a1d73a`	❌ Impostor SHA: zephyrproject-rtos/hal_nxp@`e3b7e81`	zephyrproject-rtos/[email protected]

Additional metadata changed:

Name	URL	Submodules	West cmds	`module.yml`
hal_nxp				✏

⛔ DNM label due to: 1 project with metadata changes and 1 impostor SHA

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm · 2025-02-21T09:30:07Z

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

marcin-wierzbicki · 2025-02-21T09:34:48Z

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

Thank you for the feedback! The coding style fixes are already being addressed in a separate branch, and @KevShaju will be submitting a dedicated PR for them soon. This will help keep this PR focused on its main changes while ensuring consistency across the project.

maass-hamburg · 2025-02-21T10:04:01Z

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

Thank you for the feedback! The coding style fixes are already being addressed in a separate branch, and @KevShaju will be submitting a dedicated PR for them soon. This will help keep this PR focused on its main changes while ensuring consistency across the project.

This PR will not be approved and merged, if the requested changes are not done.

marcin-wierzbicki · 2025-02-21T12:37:56Z

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

Thank you for the feedback! The coding style fixes are already being addressed in a separate branch, and @KevShaju will be submitting a dedicated PR for them soon. This will help keep this PR focused on its main changes while ensuring consistency across the project.

This PR will not be approved and merged, if the requested changes are not done.

Thank you. We have addressed all the requested changes in this PR.

manuargue · 2025-02-21T15:38:05Z

boards/nxp/s32k148_evb/doc/index.rst

+===========================
+
+This board integrates an OpenSDA debug adapter. It can be used for flashing and debugging.
+The board cannot be debugged using the ``west debug`` command, since pyOCD does not support the target.


adding west runner support should be straight forward, e.g.

jlink: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nxp/ucans32k1sic/board.cmake#L4-L9

or, s32 debug probe: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nxp/s32z2xxdc2/board.cmake#L10-L13

No need to comment on pyOCD if it's not supported for this target (only on what is supported).

Thanks for the input. Regarding the nxp_s32dbg runner, I believe nxp_s32dbg.py won’t work for the S32K148 as-is. There are some hardcoded elements, and it currently runs the gta process, whereas in this case, we need to use pegdbserver_console. It might be necessary to introduce a new runner to support this properly

boards/nxp/s32k148_evb/doc/index.rst

Support for NXP S32K148 evaluation board (s32k148_evb). The board can be debugged using gdb (see boards/nxp/s32k148_evb/doc/index.rst). Adapt samples: adc_dt, adc_sequence. Adapt tests: adc_api, gpio_basic_api, gpio_hogs. Signed-off-by: Marcin Wierzbicki <[email protected]>

Adds the c22 tja11xx driver. Signed-off-by: Kevin Shaju <[email protected]>

Add a shield for NXP ADTJA1101 Ethernet Adapter. This shield can be used with the s32k148_evb. Signed-off-by: Kevin Shaju <[email protected]>

Dat-NguyenDuy

Some minor comments

Dat-NguyenDuy · 2025-02-24T00:28:47Z

dts/arm/nxp/nxp_s32k148.dtsi

+&ftfc {
+	flash0: flash@0 {
+		compatible = "soc-nv-flash";
+		reg = <0 (DT_SIZE_M(1) + DT_SIZE_K(512))>;


Perhaps DT_SIZE_K(1536)

Dat-NguyenDuy · 2025-02-24T00:32:11Z

west.yml

@@ -203,7 +203,7 @@ manifest:
      groups:
        - hal
    - name: hal_nxp
-      revision: 2a1d73aeb863a73bb06ba8b236de7da6d3e31847
+      revision: e3b7e815ac1849d527d4a56d3d02328c532a318b


Pls use pull/509/head so that the CI can be run on this PR. You also don't need to keep pushing this PR every time there's a change on the hal_nxp side

Dat-NguyenDuy · 2025-02-24T00:54:39Z

boards/nxp/s32k148_evb/s32k148_evb.dts

+		button_4: button_1 {
+			label = "SW4";
+			gpios = <&gpioc 13 GPIO_ACTIVE_LOW>;
+			zephyr,code = <INPUT_KEY_0>;


INPUT_KEY_1?

Dat-NguyenDuy · 2025-02-24T00:55:30Z

boards/nxp/s32k148_evb/s32k148_evb.dts

+};
+
+&cpu0 {
+	clock-frequency = <112000000>;


I believe this should be 80Mhz as you have mentioned in the doc

Dat-NguyenDuy · 2025-02-24T01:02:26Z

dts/bindings/ethernet/nxp,tja11xx.yaml

@@ -0,0 +1,29 @@
+# Copyright (c) 2023 NXP


Please remove (c) here

nordicjm · 2025-02-24T07:08:53Z

boards/nxp/s32k148_evb/s32k148_evb-pinctrl.dtsi

+			bias-pull-up;
+			slew-rate = "fast";
+		};
+		group1 {


no spacing has been added

nordicjm · 2025-02-24T07:09:19Z

boards/nxp/s32k148_evb/doc/index.rst

+Supported Features
+==================
+
+The ``s32k148_evb`` board configuration supports the following hardware features:


stop marking things as resolved if they are not resolved and fix the highlighted issue

nordicjm · 2025-02-24T07:11:03Z

boards/nxp/s32k148_evb/doc/index.rst

+   ===============  ================  ===============  =====
+   Devicetree node  Devicetree alias  Label            Pin
+   ===============  ================  ===============  =====
+   led1_red         led0              LED1_RGB_RED     PTE21
+   led1_green       led1              LED1_RGB_GREEN   PTE22
+   led1_blue        led2              LED1_RGB_BLUE    PTE23
+   ===============  ================  ===============  =====


tables do not look valid e.g.

+-------------------+-----------------------------------------------+ | ``Command ID`` | Command description | +===================+===============================================+ | ``0`` | Echo | +-------------------+-----------------------------------------------+

but doc build fails to not able to tell

nordicjm · 2025-02-24T07:11:42Z

boards/shields/nxp_adtja1101/nxp_adtja1101.overlay

+
+&enet_mdio {
+	status = "okay";
+	phy: phy@0 {


nordicjm · 2025-02-24T07:12:32Z

tests/drivers/adc/adc_api/boards/s32k148_evb.overlay

+	pinctrl-0 = <&adc0_default>;
+	pinctrl-names = "default";


move above child node

nordicjm · 2025-02-24T07:13:21Z

boards/nxp/s32k148_evb/doc/img/s32k148_evb.jpg

convert to webp then put through https://tinypng.com/

zephyrbot added area: Samples Samples area: Clock Control platform: NXP S32 NXP Semiconductors, S32 area: ADC Analog-to-Digital Converter (ADC) platform: NXP Drivers NXP Semiconductors, drivers area: Ethernet labels Feb 11, 2025

zephyrbot requested review from anangl, Dat-NguyenDuy, dbaluta, decsny, dleach02, kartben, lmajewski, maass-hamburg, manuargue, mmahadevan108, nashif, nordic-krch, pdgendt and Raymond0225 February 11, 2025 08:39

zephyrbot assigned anangl Feb 11, 2025

maass-hamburg requested changes Feb 11, 2025

View reviewed changes

drivers/ethernet/nxp_enet/Kconfig Outdated Show resolved Hide resolved

manuargue assigned manuargue and unassigned anangl Feb 11, 2025

nordicjm requested changes Feb 12, 2025

View reviewed changes

manuargue requested changes Feb 12, 2025

View reviewed changes

boards/nxp/s32k148_evb/s32k148_evb.dts Outdated Show resolved Hide resolved

drivers/ethernet/phy/phy_tja1101.c Outdated Show resolved Hide resolved

drivers/ethernet/phy/phy_tja1101.c Outdated Show resolved Hide resolved

boards/nxp/s32k148_evb/s32k148_evb.yaml Show resolved Hide resolved

manuargue mentioned this pull request Feb 12, 2025

Add support for S32K148 SoC zephyrproject-rtos/hal_nxp#509

Open

kartben added this to the v4.2.0 milestone Feb 17, 2025

marcin-wierzbicki force-pushed the s32k148evb_support_pr branch 2 times, most recently from f26455d to 445c7d5 Compare February 17, 2025 09:55

zephyrbot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Feb 17, 2025

marcin-wierzbicki force-pushed the s32k148evb_support_pr branch from 445c7d5 to e2933bf Compare February 21, 2025 09:45

zephyrbot added the area: GPIO label Feb 21, 2025

marcin-wierzbicki force-pushed the s32k148evb_support_pr branch from e2933bf to ac2751f Compare February 21, 2025 12:33

zephyrbot added the area: Shields Shields (add-on boards) label Feb 21, 2025

KevShaju force-pushed the s32k148evb_support_pr branch from ac2751f to 7e879ec Compare February 21, 2025 13:36

manuargue reviewed Feb 21, 2025

View reviewed changes

marcin-wierzbicki force-pushed the s32k148evb_support_pr branch 2 times, most recently from 0f9eb96 to 1480ad1 Compare February 22, 2025 09:50

KevShaju force-pushed the s32k148evb_support_pr branch from 1480ad1 to 2f6525e Compare February 23, 2025 13:24

marcin-wierzbicki and others added 3 commits February 23, 2025 21:38

drivers: net: phy: Add tja11xx driver

3151d74

Adds the c22 tja11xx driver. Signed-off-by: Kevin Shaju <[email protected]>

boards: shields: Add shield for NXP ADTJA1101 Ethernet Adapter

02f9aaa

Add a shield for NXP ADTJA1101 Ethernet Adapter. This shield can be used with the s32k148_evb. Signed-off-by: Kevin Shaju <[email protected]>

marcin-wierzbicki force-pushed the s32k148evb_support_pr branch from 2f6525e to 02f9aaa Compare February 23, 2025 20:38

Dat-NguyenDuy requested changes Feb 24, 2025

View reviewed changes

nordicjm reviewed Feb 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for NXP S32K148 evaluation board #85555

Add support for NXP S32K148 evaluation board #85555

marcin-wierzbicki commented Feb 11, 2025 •

edited

Loading

manuargue commented Feb 11, 2025

manuargue commented Feb 11, 2025 •

edited

Loading

nordicjm Feb 12, 2025

nordicjm Feb 24, 2025

marcin-wierzbicki commented Feb 14, 2025

zephyrbot commented Feb 17, 2025 •

edited

Loading

nordicjm commented Feb 21, 2025

marcin-wierzbicki commented Feb 21, 2025

maass-hamburg commented Feb 21, 2025

marcin-wierzbicki commented Feb 21, 2025

manuargue Feb 21, 2025 •

edited

Loading

marcin-wierzbicki Feb 21, 2025

Dat-NguyenDuy left a comment

Dat-NguyenDuy Feb 24, 2025

Dat-NguyenDuy Feb 24, 2025

Dat-NguyenDuy Feb 24, 2025

Dat-NguyenDuy Feb 24, 2025

Dat-NguyenDuy Feb 24, 2025

nordicjm Feb 24, 2025

nordicjm Feb 24, 2025

nordicjm Feb 24, 2025

nordicjm Feb 24, 2025

nordicjm Feb 24, 2025

nordicjm Feb 24, 2025

	The ``s32k148_evb`` board configuration supports the following hardware features:
	The ``s32k148_evb`` board supports the following hardware features:

Add support for NXP S32K148 evaluation board #85555

Are you sure you want to change the base?

Add support for NXP S32K148 evaluation board #85555

Conversation

marcin-wierzbicki commented Feb 11, 2025 • edited Loading

manuargue commented Feb 11, 2025

manuargue commented Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcin-wierzbicki commented Feb 14, 2025

zephyrbot commented Feb 17, 2025 • edited Loading

nordicjm commented Feb 21, 2025

marcin-wierzbicki commented Feb 21, 2025

maass-hamburg commented Feb 21, 2025

marcin-wierzbicki commented Feb 21, 2025

manuargue Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dat-NguyenDuy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcin-wierzbicki commented Feb 11, 2025 •

edited

Loading

manuargue commented Feb 11, 2025 •

edited

Loading

zephyrbot commented Feb 17, 2025 •

edited

Loading

manuargue Feb 21, 2025 •

edited

Loading